New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] refactor: timestamps #53
[WIP] refactor: timestamps #53
Conversation
misc: merge from upstream
- add ms to Network Epochs - refactor and fix Slot to parse Epoch ms - update Slots tests - update PIO 'temp_main.cpp' to set dummy board time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original slots structure and unit tests were designed to match core. I would vote to keep the interface as close to core as possible. What do the other APIs do?
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 61.62% 61.71% +0.08%
==========================================
Files 41 40 -1
Lines 2567 2565 -2
==========================================
+ Hits 1582 1583 +1
+ Misses 985 982 -3
Continue to review full report at Codecov.
|
I saw they were going after matching Core. Whatever was going on, it was overflowing timestamps on <=ESP32. Timestamps also use milliseconds now https://explorer.ark.io:8443/api/v2/node/configuration. After these most recent updates, I'm able to create and sign a transactions to be broadcasted via Cpp-Client: Looks like PIO is having a fit about |
I could work on using the naming in Core though. It just needed a good housekeeping and was holding me back on IoT. Was able to send another one after the last build. And now there's a macOS build error 😭 |
@ciband SDK docs call for the following: Slot
|
@faustbrian Do you have a way to retrigger the workflow for this failing test? I suspect it’s just a random CI error. I’d feel better seeing all tests pass, and this PR is otherwise complete. Please and thank you. |
* refactor: Slots - add ms to Network Epochs - refactor and fix Slot to parse Epoch ms - update Slots tests - update PIO 'temp_main.cpp' to set dummy board time * fix: add IoT 'Slots::now' * fix: add board specific code
Proposed changes
Current Slots implementation sometimes overflows numeric timestamps on IoT.
Official Timestamps now also use milliseconds.
This PR does the following:
Networks
Timestamps to correctly use milliseconds.Slots::now()
underUSE_IOT
flag.Types of changes
Checklist