Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

plugins: cannot close websocket connections or set a message timeout #1447

Closed
alessiodf opened this issue Sep 11, 2019 · 2 comments · Fixed by #1451
Closed

plugins: cannot close websocket connections or set a message timeout #1447

alessiodf opened this issue Sep 11, 2019 · 2 comments · Fixed by #1451
Labels
Type: Refactor The pull request improves or enhances an existing implementation.

Comments

@alessiodf
Copy link
Contributor

It is currently not possible for a plugin to close an open websocket connection, as the websocket's close function is not exposed via the sandbox.

In addition it would be extremely useful to trigger an event if no data is received on the socket after x seconds since the last message, in order to detect dead sockets. This would be much better done plugin-side if #1446 were implemented but in the absence of that facility, it would need to be added to the websocket code by clearing a timer when the message event is fired and then restarting the timer again.

@ghost
Copy link

ghost commented Sep 11, 2019

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@alexbarnsley alexbarnsley added Type: Feature The issue is a request for new functionality. Type: Refactor The pull request improves or enhances an existing implementation. and removed Type: Feature The issue is a request for new functionality. labels Sep 11, 2019
@ghost
Copy link

ghost commented Sep 16, 2019

This issue has been closed. If you wish to re-open it please provide additional information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants