Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

test: add network service test cases #518

Merged
merged 4 commits into from Mar 9, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

Additional changes for #516

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. labels Mar 9, 2020
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #518 into develop will increase coverage by 0.16%.
The diff coverage is 9.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #518      +/-   ##
==========================================
+ Coverage     4.69%   4.85%   +0.16%     
==========================================
  Files           93      94       +1     
  Lines         5152    5146       -6     
  Branches      1094    1090       -4     
==========================================
+ Hits           242     250       +8     
+ Misses        4896    4882      -14     
  Partials        14      14
Impacted Files Coverage Δ
...rc/app/pages/contacts/contact-list/contact-list.ts 0% <ø> (ø) ⬆️
...pp/pages/profiles/profile-signin/profile-signin.ts 0% <0%> (ø) ⬆️
...rc/app/pages/wallet/wallet-import/wallet-import.ts 0% <0%> (ø) ⬆️
src/app/pipes/account-label/account-label.ts 0% <0%> (ø) ⬆️
src/app/pages/delegates/delegates.ts 0% <0%> (ø) ⬆️
src/app/services/market-data/market-data.ts 0% <0%> (ø) ⬆️
.../components/input-amount/input-amount.component.ts 0% <0%> (ø) ⬆️
...pp/components/wallet-picker/wallet-picker.modal.ts 0% <0%> (ø) ⬆️
...ction/transaction-response/transaction-response.ts 0% <0%> (ø) ⬆️
...s/transaction/transaction-show/transaction-show.ts 0% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e85e5...613710c. Read the comment docs.

Copy link
Contributor

@clucasalcantara clucasalcantara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine 👌

@luciorubeens luciorubeens merged commit 7ecb960 into develop Mar 9, 2020
@ghost ghost deleted the test/network-service-mock branch March 9, 2020 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants