-
Notifications
You must be signed in to change notification settings - Fork 101
feat: show error when balance low for delegate voting #587
Conversation
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Thanks a lot for this contributing @kalgoop! 🎉 We'll take a look to integrate this feature in our app 🤓 So far, looks good! 🏆 |
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kalgoop, it's already checked by the ark-api service on the confirmation screen:
The issue here is because it does not include the fee, you should change to:
-const totalAmount = transaction.getAmount();
+const totalAmount = transaction.getAmount(true);
Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information. |
App only showed error of low balance when sending tokens, not for delegate voting/unvoting.
Summary
Added error popup for low balance when voting/unvoting a delegate.
Checklist