Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: show error when balance low for delegate voting #587

Closed
wants to merge 5 commits into from

Conversation

kalgoop
Copy link
Contributor

@kalgoop kalgoop commented May 5, 2020

App only showed error of low balance when sending tokens, not for delegate voting/unvoting.

Summary

Added error popup for low balance when voting/unvoting a delegate.

Checklist

  • Ready to be merged

@ghost
Copy link

ghost commented May 5, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels May 5, 2020
@clucasalcantara
Copy link
Contributor

clucasalcantara commented May 6, 2020

Thanks a lot for this contributing @kalgoop! 🎉

We'll take a look to integrate this feature in our app 🤓

So far, looks good! 🏆

clucasalcantara
clucasalcantara previously approved these changes May 6, 2020
@ghost
Copy link

ghost commented May 6, 2020

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label May 6, 2020
Copy link
Contributor

@luciorubeens luciorubeens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kalgoop, it's already checked by the ark-api service on the confirmation screen:

https://github.com/ArkEcosystem/mobile-wallet/blob/develop/src/app/services/ark-api/ark-api.ts#L264-L266

The issue here is because it does not include the fee, you should change to:

-const totalAmount = transaction.getAmount();
+const totalAmount = transaction.getAmount(true);

@ghost
Copy link

ghost commented Jun 2, 2020

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants