Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: use recipient address to sign transaction #683

Merged
merged 3 commits into from
Sep 24, 2020
Merged

fix: use recipient address to sign transaction #683

merged 3 commits into from
Sep 24, 2020

Conversation

luciorubeens
Copy link
Contributor

Summary

Use the recipient field to sign transactions.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Sep 23, 2020
clucasalcantara
clucasalcantara approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@clucasalcantara clucasalcantara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

Just a question recipient and recipientId are the same field or the transaction could be recognized using both?

@luciorubeens luciorubeens merged commit b1050f6 into master Sep 24, 2020
@luciorubeens luciorubeens deleted the fix/send-transaction branch September 24, 2020 14:15
@ghost ghost mentioned this pull request Sep 27, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clucasalcantara clucasalcantara clucasalcantara approved these changes

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luciorubeens @clucasalcantara