Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat(crypto): implement bcryptjs as argon2 alternative #588

Merged
merged 5 commits into from
Jul 30, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

The argon2 dependencies cause some issues for electron so as a temporary solution we'll use bcrypt.

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #588 into master will decrease coverage by 10.86%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #588       +/-   ##
===========================================
- Coverage   62.50%   51.63%   -10.87%     
===========================================
  Files          74       47       -27     
  Lines        1248      641      -607     
  Branches       90       56       -34     
===========================================
- Hits          780      331      -449     
+ Misses        440      298      -142     
+ Partials       28       12       -16     
Flag Coverage Δ
#unit 51.63% <100.00%> (-10.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/platform-sdk-crypto/src/bcrypt.ts 100.00% <100.00%> (ø)
packages/platform-sdk-profiles/src/container.ts
...m-sdk-profiles/src/repositories/data-repository.ts
...ckages/platform-sdk-profiles/src/profile.models.ts
...kages/platform-sdk-profiles/src/contact-address.ts
...dk-profiles/src/repositories/contact-repository.ts
...ages/platform-sdk-profiles/src/container.models.ts
...ckages/platform-sdk-profiles/src/storage/memory.ts
...ofiles/src/repositories/notification-repository.ts
...sdk-profiles/src/repositories/plugin-repository.ts
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f450019...33fd3b7. Read the comment docs.

@faustbrian faustbrian merged commit 1e74f30 into master Jul 30, 2020
@faustbrian faustbrian deleted the bcryptjs branch July 30, 2020 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant