Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

feat(profiles): store exchange currency in wallet data #690

Merged
merged 5 commits into from
Sep 2, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 1, 2020

Summary

  • Stores the exchange currency in addition to the exchange rate on a wallet.

  • Updates the market service to fetch each coins exchange rate only once per profile.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #690 into master will increase coverage by 0.03%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   63.04%   63.08%   +0.03%     
==========================================
  Files         104      104              
  Lines        2200     2205       +5     
  Branches      240      240              
==========================================
+ Hits         1387     1391       +4     
- Misses        733      734       +1     
  Partials       80       80              
Flag Coverage Δ
#unit 63.08% <88.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/platform-sdk-profiles/src/wallets/wallet.ts 60.91% <0.00%> (-0.36%) ⬇️
.../src/environment/services/exchange-rate-service.ts 94.73% <100.00%> (+0.98%) ⬆️
...platform-sdk-profiles/src/wallets/wallet.models.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0132ff5...0f4bea4. Read the comment docs.

@faustbrian faustbrian merged commit 3d9f3d5 into master Sep 2, 2020
@faustbrian faustbrian deleted the feat/exchange-currency branch September 2, 2020 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants