Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create more deserializers #25

Merged
merged 1 commit into from Jul 30, 2018
Merged

Create more deserializers #25

merged 1 commit into from Jul 30, 2018

Conversation

roks0n
Copy link
Contributor

@roks0n roks0n commented Jul 30, 2018

Proposed changes

Created the rest of the deserializers as per othre crypto libraries.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

None

@roks0n roks0n merged commit 488f5f4 into ArkEcosystem:develop Jul 30, 2018
@roks0n roks0n deleted the deserializers branch July 30, 2018 21:20
@codecov-io
Copy link

Codecov Report

Merging #25 into develop will increase coverage by 4.41%.
The diff coverage is 96.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #25      +/-   ##
===========================================
+ Coverage    72.32%   76.74%   +4.41%     
===========================================
  Files           32       36       +4     
  Lines          589      645      +56     
  Branches        54       58       +4     
===========================================
+ Hits           426      495      +69     
+ Misses         136      128       -8     
+ Partials        27       22       -5
Impacted Files Coverage Δ
crypto/deserializer.py 75.38% <100%> (+12.3%) ⬆️
crypto/resources/transaction.py 88.49% <100%> (+5.3%) ⬆️
...ons/deserializers/second_signature_registration.py 100% <100%> (ø)
...ions/deserializers/multi_signature_registration.py 100% <100%> (ø)
...ransactions/deserializers/delegate_registration.py 100% <100%> (ø)
crypto/transactions/deserializers/vote.py 88.88% <88.88%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f27c6...5c3c3c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants