Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing functionalities (identity, slot) + additional tests #26

Merged
merged 5 commits into from Aug 13, 2018
Merged

Add missing functionalities (identity, slot) + additional tests #26

merged 5 commits into from Aug 13, 2018

Conversation

roks0n
Copy link
Contributor

@roks0n roks0n commented Aug 13, 2018

Proposed changes

Added missing functionalities

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

None

@roks0n roks0n requested a review from tsifrer August 13, 2018 19:33
@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #26 into develop will increase coverage by 0.55%.
The diff coverage is 90.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #26      +/-   ##
===========================================
+ Coverage    76.74%   77.29%   +0.55%     
===========================================
  Files           36       37       +1     
  Lines          645      674      +29     
  Branches        58       61       +3     
===========================================
+ Hits           495      521      +26     
  Misses         128      128              
- Partials        22       25       +3
Impacted Files Coverage Δ
crypto/message.py 82.6% <100%> (ø) ⬆️
crypto/slot.py 100% <100%> (ø) ⬆️
crypto/identity/keys.py 100% <100%> (ø) ⬆️
crypto/identity/address.py 92.85% <87.5%> (-7.15%) ⬇️
crypto/identity/wif.py 90.9% <90.9%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488f5f4...217ddad. Read the comment docs.

@roks0n roks0n merged commit de6fc08 into ArkEcosystem:develop Aug 13, 2018
@roks0n roks0n deleted the changes branch August 13, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants