Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor message module to better reflect other crypto libraries #36

Merged
merged 4 commits into from Aug 20, 2018
Merged

Refactor message module to better reflect other crypto libraries #36

merged 4 commits into from Aug 20, 2018

Conversation

roks0n
Copy link
Contributor

@roks0n roks0n commented Aug 20, 2018

Proposed changes

The following change resolves #30 and #35, where verify() method in the message raises an exception again and refactors the message module to reflect other crypto libraries.

After completing these changes I've run the TransferBuilder and successfully made a transaction - this is just to prove that nothing regarding signing didn't break.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Test (adding missing tests or fixing existing tests)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@roks0n roks0n changed the title Refactor message Refactor message module to better reflect other crypto libraries Aug 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #36 into develop will increase coverage by 0.24%.
The diff coverage is 86.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #36      +/-   ##
===========================================
+ Coverage    77.51%   77.76%   +0.24%     
===========================================
  Files           38       38              
  Lines          676      697      +21     
  Branches        60       62       +2     
===========================================
+ Hits           524      542      +18     
- Misses         126      128       +2     
- Partials        26       27       +1
Impacted Files Coverage Δ
crypto/exceptions.py 100% <100%> (ø) ⬆️
crypto/message.py 100% <100%> (ø) ⬆️
crypto/identity/private_key.py 100% <100%> (+11.76%) ⬆️
crypto/transactions/builder/base.py 92.3% <100%> (ø) ⬆️
crypto/resources/transaction.py 85% <45.45%> (-3.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b03159d...0ef382c. Read the comment docs.

@roks0n roks0n merged commit f05605e into ArkEcosystem:develop Aug 20, 2018
@roks0n roks0n deleted the refactor-message branch August 20, 2018 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants