Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes badges / contributors link in readme #43

Merged
merged 1 commit into from Aug 24, 2018
Merged

chore: fixes badges / contributors link in readme #43

merged 1 commit into from Aug 24, 2018

Conversation

dated
Copy link
Contributor

@dated dated commented Aug 24, 2018

Proposed changes

This pull request applies the badge style outlined in https://github.com/ArkEcosystem/boilerplate and fixes the All Contributors link.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov-io
Copy link

Codecov Report

Merging #43 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #43   +/-   ##
========================================
  Coverage    77.52%   77.52%           
========================================
  Files           39       39           
  Lines          712      712           
  Branches        70       70           
========================================
  Hits           552      552           
  Misses         129      129           
  Partials        31       31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4abefe...eb386e8. Read the comment docs.

Copy link
Contributor

@roks0n roks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you good Sir.

@roks0n roks0n merged commit a1160f8 into ArkEcosystem:develop Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants