Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vote, 2nd signature reg. and delegate registration + minor refactor #44

Merged
merged 6 commits into from Aug 25, 2018
Merged

Conversation

roks0n
Copy link
Contributor

@roks0n roks0n commented Aug 25, 2018

Proposed changes

This PR fixes following transactions:

  • Vote: proof
  • 2nd Signature Registration: proof
  • Delegate registration: proof

Along with above fixes I've also removed some unsued methods and removes name Transaction from the Builder's class names. It also fixes incorect naming of a transaction.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

None

@codecov-io
Copy link

Codecov Report

Merging #44 into develop will increase coverage by 1.95%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #44      +/-   ##
===========================================
+ Coverage    77.52%   79.48%   +1.95%     
===========================================
  Files           39       39              
  Lines          712      697      -15     
  Branches        70       70              
===========================================
+ Hits           552      554       +2     
+ Misses         129      112      -17     
  Partials        31       31
Impacted Files Coverage Δ
crypto/transactions/builder/timelock_transfer.py 0% <0%> (ø) ⬆️
...rypto/transactions/builder/delegate_resignation.py 0% <0%> (ø) ⬆️
crypto/transactions/builder/ipfs.py 0% <0%> (ø) ⬆️
crypto/transactions/builder/multi_payment.py 0% <0%> (ø) ⬆️
crypto/transactions/builder/base.py 92.3% <100%> (-0.55%) ⬇️
crypto/transactions/builder/transfer.py 81.81% <100%> (ø) ⬆️
crypto/transactions/builder/vote.py 84.61% <100%> (+17.94%) ⬆️
...ypto/transactions/builder/delegate_registration.py 85.71% <100%> (+7.93%) ⬆️
crypto/transactions/transaction.py 85% <100%> (ø) ⬆️
...ansactions/builder/multi_signature_registration.py 100% <100%> (+26.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1160f8...4377f98. Read the comment docs.

@roks0n roks0n merged commit 085176a into ArkEcosystem:develop Aug 25, 2018
@roks0n roks0n deleted the refactor branch August 25, 2018 20:42
@roks0n roks0n changed the title Refactor Fix vote, 2nd signature reg. and delegate registration + minor refactor Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants