Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add blockchain endpoint #104

Merged
merged 9 commits into from
Jul 12, 2019
Merged

feat(api): add blockchain endpoint #104

merged 9 commits into from
Jul 12, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Was missing from prior versions.

This PR does the following:

  • added Blockchain Path and API Endpoint.
  • added Blockchain mock & tests.
  • updated CMake files.
  • updated documentation.
  • updated examples.
  • added to changelog.

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

sleepdefic1t and others added 4 commits June 1, 2019 15:47
- added Blockchain Path and API Endpoint.
- added Block mock & tests.
- updated CMake files.
- updated documentation.
- updated examples.
- added to changelog.
@ghost ghost added Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Jul 11, 2019
@codecov-io
Copy link

Codecov Report

Merging #104 into develop will increase coverage by 70.66%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #104       +/-   ##
===========================================
+ Coverage    26.93%   97.6%   +70.66%     
===========================================
  Files           14      15        +1     
  Lines          245     250        +5     
===========================================
+ Hits            66     244      +178     
+ Misses         179       6      -173
Impacted Files Coverage Δ
src/http/os/http.cpp 100% <ø> (+48.88%) ⬆️
src/api/paths.cpp 96.27% <0%> (+96.27%) ⬆️
src/include/cpp-client/http/http.h 100% <100%> (+40%) ⬆️
...c/include/cpp-client/api/blockchain/blockchain.hpp 100% <100%> (ø)
src/include/cpp-client/api/abstract.h 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f39aebe...710c995. Read the comment docs.

sleepdefic1t and others added 5 commits July 11, 2019 07:49
- added Blockchain Path and API Endpoint.
- added Block mock & tests.
- updated CMake files.
- updated documentation.
- updated examples.
- added to changelog.
@faustbrian faustbrian merged commit b1f6955 into ArkEcosystemArchive:develop Jul 12, 2019
@sleepdefic1t sleepdefic1t deleted the feat/blockchain branch July 15, 2019 18:56
This was referenced Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants