Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update build to be out of source #115

Merged

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 13, 2019

Updated build to be out of source to clean up the workspace
and added build scripts to enforce this.

Re-enabled cmake_example builds in CI.

Removed cmake_example .gitmodules file. This historically caused
git to do funny things having a nested .gitmodules in the source
tree. Commented out the submodule clone in the CMakeList.txt and
setup the build script to mimic the submodule clone by copying the
cpp-crypto source into the correct directory.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Updated build to be out of source to clean up the workspace
and added build scripts to enforce this.

Re-enabled  cmake_example builds in CI.

Removed cmake_example .gitmodules file.  This historically caused
git to do funny things having a nested .gitmodules in the source
tree.  Commented out the submodule clone in the CMakeList.txt and
setup the build script to mimic the submodule clone by copying the
cpp-crypto source into the correct directory.
@ghost
Copy link

ghost commented Aug 13, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Aug 13, 2019
@ciband
Copy link
Contributor Author

ciband commented Aug 13, 2019

Clang tidy is failing and I'm not sure why. There is a lot of noise in the output from curl and what not.

I think a future PR to limit clang tidy file processing to not process submodules is needed.

We can either merge this PR as is or we can hold until we can reduce the clang tidy output such that the error is easier to spot.

@ciband
Copy link
Contributor Author

ciband commented Aug 13, 2019

Update: It appears that clang tidy is failing on a curl source file:

Line 63249:
error: error reading '/home/circleci/project/src/lib/curl/src/tool_hugehelp.c' [clang-diagnostic-error]

Line 177893:
error: error reading '/home/circleci/project/src/lib/curl/tests/libtest/lib1521.c' [clang-diagnostic-error]

I do not know why.

@faustbrian
Copy link
Contributor

@ciband conflicts

@ciband
Copy link
Contributor Author

ciband commented Aug 14, 2019

@sleepdefic1t , @faustbrian Clang build failure looks like a circle ci issue. I am unable to re-trigger, if desired.

@sleepdefic1t sleepdefic1t self-requested a review August 15, 2019 06:17
@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Aug 15, 2019
@ghost
Copy link

ghost commented Aug 15, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Aug 15, 2019
@ghost
Copy link

ghost commented Aug 15, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit c8c1fdf into ArkEcosystemArchive:develop Aug 15, 2019
@ghost
Copy link

ghost commented Aug 15, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants