Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add debug support for VS Code #116

Merged

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 13, 2019

Added support for VS Code line by line debugging
Added support for building from VS Code IDE
Added support for GTest extension within VS Code

This ultimately adds easy line by line debugging support for
Windows, Mac, and Linux.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Added support for VS Code line by line debugging
Added support for building from VS Code IDE
Added support for GTest extension within VS Code

This ultimately adds easy line by line debugging support for
Windows, Mac, and Linux.
@ghost
Copy link

ghost commented Aug 13, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels Aug 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #116 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #116   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           15     15           
  Lines          249    249           
======================================
  Hits           249    249

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b10dc5...e7e028a. Read the comment docs.

@sleepdefic1t sleepdefic1t self-requested a review August 13, 2019 23:08
@ghost
Copy link

ghost commented Aug 13, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Aug 13, 2019
@faustbrian faustbrian merged commit 9af5968 into ArkEcosystemArchive:develop Aug 14, 2019
@ghost
Copy link

ghost commented Aug 14, 2019

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Aug 14, 2019
@ghost
Copy link

ghost commented Aug 14, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@sleepdefic1t sleepdefic1t mentioned this pull request Oct 7, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants