Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add support for VS2019 #119

Merged
merged 2 commits into from Sep 3, 2019
Merged

chore: Add support for VS2019 #119

merged 2 commits into from Sep 3, 2019

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 30, 2019 •
edited

Added support for VS2019 and maintained support for VS2017.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ciband
chore: Add support for VS2019
6dc3308 
Added support for VS2019 and maintained support for VS2017.
@ghost
Copy link

ghost commented Aug 30, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Aug 30, 2019
@ciband
Copy link
Contributor Author

ciband commented Aug 30, 2019

VS2019 targets work under VS2019 IDE. VS2017 targets work under VS2017 IDE and VS2019 IDE. The VS2019 targets to not work, which is expected. They give reasonable diagnostics as to why they do not work.

This PR is ready for review.

@ciband
Copy link
Contributor Author

ciband commented Sep 1, 2019

Appveyor build failure is due to no appveyor config file. I will be submitting a PR to fix this. This is not related to this change. The JSON file is just for IDE config.

@sleepdefic1t sleepdefic1t self-requested a review September 1, 2019 19:20
@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 1, 2019
@ghost
Copy link

ghost commented Sep 1, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost mentioned this pull request Sep 1, 2019
Closed
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Sep 3, 2019
@ghost
Copy link

ghost commented Sep 3, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 0cb71f0 into ArkEcosystemArchive:develop Sep 3, 2019
@ghost
Copy link

ghost commented Sep 3, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@ghost ghost mentioned this pull request Sep 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepdefic1t sleepdefic1t sleepdefic1t approved these changes

@faustbrian faustbrian faustbrian approved these changes

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciband @sleepdefic1t @faustbrian