Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: transactions/fees endpoint #125

Closed
wants to merge 1 commit into from
Closed

feat: transactions/fees endpoint #125

wants to merge 1 commit into from

Conversation

dated
Copy link
Contributor

@dated dated commented Sep 9, 2019 •
edited
Loading

Adds the transaction/fees endpoint.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost
Copy link

ghost commented Sep 9, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels Sep 9, 2019
@ciband ciband self-requested a review September 9, 2019 13:51
@ciband
Copy link
Contributor

ciband commented Sep 9, 2019

Looks good to me

ciband
ciband reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@ciband ciband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ghost
Copy link

ghost commented Sep 11, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 11, 2019
@sleepdefic1t
Copy link
Contributor

@faustbrian
This looks good to go 👍

Thank you, @dated

@dated dated closed this Sep 13, 2019
@ghost
Copy link

ghost commented Sep 13, 2019

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

@dated dated deleted the feat/tx-fees-endpoint branch September 13, 2019 06:25
@ghost ghost mentioned this pull request Sep 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciband ciband ciband left review comments

@sleepdefic1t sleepdefic1t sleepdefic1t approved these changes

@faustbrian faustbrian Awaiting requested review from faustbrian

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Feature The issue is a request for new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dated @ciband @sleepdefic1t