Bug: fix windows curl

[ciband]

Added additional flags to explicitly set linking with static CRT as well as producing and linking with static libraries.

Fixes #123

What kind of change does this PR introduce?

• Bugfix
• Feature
• Refactor
• Performance
• Tests
• Build
• Documentation
• Code style update
• Continuous Integration
• Other, please describe:

Does this PR introduce a breaking change?

• Yes
• No

Does this PR release a new version?

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• It's submitted to the develop branch, not the master branch
• All tests are passing
• New/updated tests are included

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

[ghost]

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[ghost]

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

[sleepdefic1t]

@ciband

I got this to build and passed tests on my system (macOS) with a few tweaks.

I changed a couple parts and ran brew install openssl.
(changes in PR comments; the brew bit just add to config.yml).

Thank you for working on this.
Much appreciated, sir!

[ciband]

Do thoses changes force the apple builds to use an installed version of openssl instead of our internally build version?

Is that desirable vs. all platforms running the same thing?

[sleepdefic1t]

@ciband
It totally does use an installed version.

Yeah, it'd be preferred to have all builds do the same thing.

If you have anything you'd like me to try, just let me know 👍

[ciband]

@sleepdefic1t Your changes are correct. I got curl and openssl twisted in my head. Just pushed them.

[ciband]

Not sure why AppVeyor failed. The release build passed but the debug build did not.

Logs show that the build was successful but some error occurred before tests could be built/ran. This seems like a CI issue to me.

@faustbrian can you rerun just the debug build to test? I do not have access.

Thanks.

[sleepdefic1t]

@faustbrian
Can you retrigger Appveyor when you get a moment, please and thank you.

[faustbrian]

@ciband conflicts

[faustbrian]

https://ci.appveyor.com/project/faustbrian/cpp-client/builds/27587615/job/etm2hrawtocnsp6q

[ciband]

@faustbrian same issue here as in cpp-crypto. I fixed the conflict and merged develop into the PR. When I go to push I get an error. Will investigate later.

[codecov]

Codecov Report

Merging #126 into develop will increase coverage by 20.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #126       +/-   ##
==========================================
+ Coverage    79.47%   100%   +20.52%     
==========================================
  Files           26     16       -10     
  Lines          497    376      -121     
==========================================
- Hits           395    376       -19     
+ Misses         102      0      -102

Impacted Files	Coverage Δ
src/api/blocks/blocks.cpp
src/include/cpp-client/api/rounds/rounds.h
src/api/votes/votes.cpp
src/api/node/node.cpp
src/api/delegates/delegates.cpp
src/api/rounds/rounds.cpp
src/api/wallets/wallets.cpp
src/api/transactions/transactions.cpp
src/api/peers/peers.cpp
src/api/blockchain/blockchain.cpp
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba9d18...1100c6d. Read the comment docs.

[ghost]

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

[sleepdefic1t]

@ciband
#132 May help kick start CI Actions after it's merged and pulled in.

If not, you may have to redo the PR from a fresh fork.
Hopefully we can avoid that though 👍

[ciband]

Looks like the same Appveyor issues. With the changes the code builds, which was the main problem. CI will be fixed in a github windows ci commit.

[ghost]

Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days.

[ghost]

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.