Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CodeClimate Improvements #149

Merged
merged 4 commits into from
Oct 19, 2019
Merged

chore: CodeClimate Improvements #149

merged 4 commits into from
Oct 19, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Summary

This PR resolves a couple code issues flagged in CodeClimate, CodeFactor, and Codacy.

Specifically, this PR does the following:

  • .appveyor.yml
    • remove white space.
  • host.cpp
    • use string.find() for correct host:port position.

Checklist

  • Ready to be merged

@sleepdefic1t
chore: codeclimate improvements
dd4755f 
- remove white space from .appveyor.yml.
- use string.find() for correct host:port position.
@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Oct 17, 2019
@sleepdefic1t
Copy link
Contributor Author

@faustbrian good to go 👍

@sleepdefic1t
Copy link
Contributor Author

@faustbrian

Failing Coverage throws:

  • Error: you must supply a CC_TEST_REPORTER_ID ENV variable or pass it via the -r flag.

This is not related to these changes and is consistent with purpose of #148.
Coverage should run properly for subsequent PR's after merging.

@faustbrian faustbrian merged commit acde1df into ArkEcosystemArchive:develop Oct 19, 2019
@ghost ghost mentioned this pull request Oct 20, 2019
Closed
@sleepdefic1t sleepdefic1t deleted the chore/cc-improvements branch October 22, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sleepdefic1t @faustbrian