Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: hide mocked api coverage #153

Merged
merged 1 commit into from Oct 23, 2019
Merged

ci: hide mocked api coverage #153

merged 1 commit into from Oct 23, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Summary

Mocked API show 0% coverage even though they're all tested.

This PR hides mocked API and other unused folders from coverage reports.

The Paths, Connection, Host, and HTTP classes are reported correctly.

A subsequent PR should address refactoring for testability and accurate coverage reports.

Checklist

  • Ready to be merged

## Summary

Mocked API show 0% coverage even though they're all tested.

This PR hides mocked API and unused folders from coverage reports.

The `Paths`, `Connection`, `Host`, and `HTTP` classes are reported correctly.

A subsequent PR should address refactoring mocks to be accurately reflected in coverage reports.

## Checklist

- [x] Ready to be merged
@ghost ghost added the Complexity: Low Less than 64 lines changed. label Oct 22, 2019
@faustbrian faustbrian merged commit 6880d5a into ArkEcosystemArchive:develop Oct 23, 2019
@sleepdefic1t sleepdefic1t deleted the ci/hide-mock-api branch October 28, 2019 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants