Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to use official googletest repo #166

Closed
wants to merge 1 commit into from

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Nov 5, 2019

Summary

Google has official merged my PR to add esp8266 support to googletest.
This switches the dependency to use the official repo instead of my
fork.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Google has official merged my PR to add esp8266 support to googletest.
This switches the dependency to use the official repo instead of my
fork.
@ghost
Copy link

ghost commented Nov 5, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Nov 5, 2019
Copy link
Contributor

@sleepdefic1t sleepdefic1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ciband
Can you pin this to a release? Is it in v1.10.0?

@ciband
Copy link
Contributor Author

ciband commented Nov 5, 2019

Sadly no, this merge was after the v1.10.0 release. Once the do one, we can snap it to the release. Until then, this is the best we can do. Figured this is better than pointing to my fork.

@sleepdefic1t
Copy link
Contributor

@ciband

tbh, I'd rather wait for an official release.
It's already pointing at your fork, so we have a little control atm.

Can you keep an eye out and push new PRs/reopen these when Google does their next release?

@ciband
Copy link
Contributor Author

ciband commented Nov 5, 2019

@sleepdefic1t That's fine. I will be watcing.

@sleepdefic1t
Copy link
Contributor

Thank you, @ciband

Closing this for now 👍

@ghost
Copy link

ghost commented Nov 5, 2019

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants