Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support https #195

Merged
merged 3 commits into from
May 1, 2020
Merged

feat: support https #195

merged 3 commits into from
May 1, 2020

Conversation

sleepdefic1t
Copy link
Contributor

Summary

Add Https support for OS and IoT builds.

  • 'host.cpp': add support for url prefixes (http(s)://)<address>:<port>.
  • 'http.cpp': refactor and add support for Https.
  • 'test/http': update tests to reflect changes.
  • update arduino examples.
  • update CHANGELOG.

This resolves #191 & #192

Checklist

  • Documentation
  • Tests
  • Ready to be merged

- 'host.cpp': add support for url prefixes ((http(s)://)<address>:<port>
- refactor 'http.cpp' in OS & IoT and add support for Https.
- update 'http' tests to reflect changes.
- update arduino examples.
@ghost ghost added the Type: Feature The issue is a request for new functionality. label Apr 28, 2020
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #195 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #195   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          483       472   -11     
=========================================
- Hits           483       472   -11     
Impacted Files Coverage Δ
src/host/host.cpp 100.00% <100.00%> (ø)
src/http/os/http.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cbb096...70e4e6b. Read the comment docs.

@faustbrian faustbrian merged commit 8658701 into develop May 1, 2020
@ghost ghost deleted the feat/support-https branch May 1, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants