refactor: cmake setup #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor cmake and project organization to be more modular and to better conform to best practices.
Corrected tests link errors by reverting GTest back to hunter package instead of submodule. Removed Windows compile flags for /MT
Changed tests to just compare native types instead of converting to strings when not needed.
Fixed PlatformIO builds to work with new folder structure. Removed submodule python script in favor of just ignoring the directory. This will allow desktop and IoT to better co-exist in the same source tree. Remove [common] section of test/platformio.ini as it did not seem to actually be respected.
|
build failures are due to test failures dealing with timestamp. This is corrected in #22. |
Added missing adapter macro to GTest adapter. Will submit PR to AUnit library for proper fix.
|
macOS builds are not running (and failing the check) due to some sort of CircleCI admin issue. Not a problem with the PR. I do not know what the expect results from CircleCI are. This appears to be running just CI on my branch and not on the PR. If this is the case then macOS builds will always fail for my PRs since I do not have a paid macOS plan. |
|
Can confirm this passes tests on macOS. CI issue is also discussed here: Cpp-Crypto #27. |
faustbrian
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactored cmake to make the project easier to include in end-user applications. Updated PlatformIO as needed. Attempted to follow best practices for cmake and C++.
Types of changes
Checklist
Further comments
This change will support the creation of a "HelloArk" getting started project and allow cpp-client to be cmake "add_subdirectory" friendly to allow anyone to include it in their project.