New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: library config examples' paths #69
fix: library config examples' paths #69
Conversation
- this change also fixes the 'platformio_example' path
This reverts commit d12af6f.
PlatformIO uses globbing for 'examples' paths. https://docs.platformio.org/en/latest/librarymanager/config.html#examples
@sleepdefic1t Thanks for submitting this pull request, a maintainer will get back to you shortly! |
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
@sleepdefic1t A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 77.67% 77.67%
=======================================
Files 22 22
Lines 318 318
=======================================
Hits 247 247
Misses 71 71 Continue to review full report at Codecov.
|
@sleepdefic1t Your pull request has been merged but was not assigned a bounty tier. @air1one @faustbrian - please assign a bounty tier to this pull request in the next few days. |
Proposed changes
PlatformIO uses globbing in
library.json
for the 'examples' paths.This PR drops explicit path naming in favor of the wildcard(*) syntax.
This allows SDK examples to be properly displayed in the PIO library manager.
Types of changes
Checklist