Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Automate Arduino Script #72

Merged
merged 8 commits into from Feb 13, 2019
Merged

chore: Automate Arduino Script #72

merged 8 commits into from Feb 13, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR modifies the extras/ARDUINO_IDE.sh script to allow the passing of --auto to skip interface prompts.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

This is primarily an improvement to aid CI and Arduino releases.

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Feb 11, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested review from air1one and faustbrian February 11, 2019 17:27
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. Complexity: Low Less than 64 lines changed. labels Feb 11, 2019
@ghost
Copy link

ghost commented Feb 11, 2019

@sleepdefic1t Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@codecov-io
Copy link

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   77.67%   77.67%           
=======================================
  Files          22       22           
  Lines         318      318           
=======================================
  Hits          247      247           
  Misses         71       71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc9de4...57d8396. Read the comment docs.

@sleepdefic1t sleepdefic1t changed the title Chore/automate arduino script chore: Automate Arduino Script Feb 11, 2019
@sleepdefic1t sleepdefic1t mentioned this pull request Feb 11, 2019
12 tasks
@faustbrian faustbrian merged commit 3a30de9 into ArkEcosystemArchive:master Feb 13, 2019
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 13, 2019
@sleepdefic1t sleepdefic1t deleted the chore/automate-arduino-script branch February 15, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants