Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Cleanup and Prep for Arduino IDE #75

Merged
merged 14 commits into from
Feb 14, 2019
Merged

misc: Cleanup and Prep for Arduino IDE #75

merged 14 commits into from
Feb 14, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR is cleanup prep for upcoming Arduino IDE branch.
It removes unnecessary files and moves others to a cleaner more Arduino-friendly layout.
It also properly configures ./library.json to export packages correctly for external library managers.

The following has been changed:

  • changed package export settings in ./library.json.
  • removed submodule from cmake_example.
  • moved ./docs to ./extras/docs.
  • moved ./src/stl to ./src/lib/stl.
  • removed .appveyor.yml.
  • removed ./CMakeSettings.json.

All tests pass locally:

  • macOS - CMake.
  • macOS - PlatformIO.
  • macOS - Arduino IDE

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Feb 14, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 14, 2019 00:49
@ghost ghost added the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 14, 2019
@ghost
Copy link

ghost commented Feb 14, 2019

@sleepdefic1t Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost ghost added the Complexity: Medium Less than 256 lines changed. label Feb 14, 2019
@faustbrian faustbrian merged commit 690780a into ArkEcosystemArchive:master Feb 14, 2019
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 14, 2019
@sleepdefic1t sleepdefic1t changed the title mics: Cleanup and Prep for Arduino IDE misc: Cleanup and Prep for Arduino IDE Feb 14, 2019
@sleepdefic1t sleepdefic1t deleted the chore/cleanup branch February 15, 2019 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Less than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants