Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove STL library #78

Merged
merged 8 commits into from Feb 17, 2019
Merged

chore: Remove STL library #78

merged 8 commits into from Feb 17, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

The STL library is not used in Cpp-Client for any platform.
This PR removes STL files and its reference in /helpers/client_helpers.h.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Feb 15, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 15, 2019 21:23
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Feb 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #78   +/-   ##
======================================
  Coverage    96.4%   96.4%           
======================================
  Files          14      14           
  Lines         250     250           
======================================
  Hits          241     241           
  Misses          9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8c1e2...3c6b29b. Read the comment docs.

@faustbrian faustbrian merged commit a978ae9 into ArkEcosystemArchive:master Feb 17, 2019
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 17, 2019
@sleepdefic1t sleepdefic1t deleted the chore/rm-stl branch February 19, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: High More than 256 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants