Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump version #80

Merged
merged 11 commits into from Feb 17, 2019
Merged

chore: bump version #80

merged 11 commits into from Feb 17, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR bumps version to 1.2.0 and will match incoming 1.2.0-arduino tag.
see #79 for more info.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Feb 15, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 15, 2019 22:05
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Feb 15, 2019
- contains tags related to PIO builds and board library selection.
@codecov-io
Copy link

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    96.4%   96.4%           
======================================
  Files          14      14           
  Lines         250     250           
======================================
  Hits          241     241           
  Misses          9       9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8c1e2...9fddb98. Read the comment docs.

@ghost
Copy link

ghost commented Feb 17, 2019

@sleepdefic1t The ci/circleci: build-linux-gcc7 job is failing as of 13aed2edd274d38a7f08b6fd8720cc49f416d42b. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystemArchive ArkEcosystemArchive deleted a comment Feb 17, 2019
@@ -7,6 +7,24 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## Unreleased

## [1.2.0] - 2019-02-16
## [1.2.0-arduino] - 2019-02-16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we really required to do duplicate tags for the same code? Shouldn't everything work with a single tag now that the arduino config is setup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and no.

Arduino branch will have a different folder structure compatible with Arduino’s library manager.

The Arduino tags should target the Arduino branch; regular tag should target master.

what’s basically going on:
master | 1.2.0
master >> Arduino Script >> arduino branch | 1.2.0-arduino

Using two releases is per @kristjank and discussion here:
https://forum.arduino.cc/index.php?topic=596617.0

The Library Manager indexer job just works off of Git tags. As long as the tag points to something that is compliant, it's fine. You could have one branch of the repo with the Library Manager compatible structure that you point the Library Manager tags at, and another branch of the repository with your existing structure. You should also be able to create tags that point to the non-compliant branch and the Library Manager indexer should just ignore those.

The alternative would be a completely separate Arduino repo with nearly identical code, just laid out differently than PlatformIO and Desktop builds.

I’m open to more discussion if you feel it’s warranted though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense now, thanks for the link.

@faustbrian faustbrian merged commit a068603 into ArkEcosystemArchive:master Feb 17, 2019
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 17, 2019
@sleepdefic1t sleepdefic1t deleted the chore/bump-version branch February 19, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants