style: formatting, coverage, and improvements #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Undetermined
Codecov Report
@@ Coverage Diff @@
## develop #121 +/- ##
===========================================
+ Coverage 91.44% 91.82% +0.37%
===========================================
Files 33 33
Lines 877 856 -21
===========================================
- Hits 802 786 -16
+ Misses 75 70 -5
Continue to review full report at Codecov.
|
ghost
mentioned this pull request
|
Codacy should ignore Current Codacy analysis with those filtered at : codacy.com/sleepdefic1t/cpp-crypto. This one is good to go 馃憤 |
sleepdefic1t
requested review from
faustbrian,
kristjank and
spkjp
as code owners
18 tasks
|
Passing Codacy here (ignoring changelog): codacy/sleepdefic1t/cpp-crypto. This is good to go otherwise, @faustbrian @supaiku0 @kristjank 馃憤 |
faustbrian
previously approved these changes
Aug 20, 2019
|
@sleepdefic1t conflicts |
remove empty line. remove unused def. fix PR#
readd lib dir
codecov miss
add invalid-versioned network test
faustbrian
approved these changes
Aug 20, 2019
ghost
removed
the
Status: In Progress
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates style and improves formatting, coverage, and the overall implementation.
These are basically fixes for things showing up in Codacy/Codefactor/Codecov.
I did not attempt to update Transactions-related classes and tests; that's next for updates.
Changelog, I think Codacy needs configured for the format our Organization uses.
I followed as closely to keepachangelog.com as possible,
but Codacy still complains 馃し鈥嶁檪
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
The PR fulfills these requirements:
developbranch, not themasterbranch