Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing initialization for transaction version #124

Merged
merged 3 commits into from Aug 7, 2019
Merged

fix: Add missing initialization for transaction version #124

merged 3 commits into from Aug 7, 2019

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Aug 7, 2019 •
edited

  • Added explicit default ctors/assign for copy/move to builder
  • Changed builder sign function to return void and pass transaction in by reference to avoid copies.
  • Updated transaction tests to check for version.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ciband
fix: Add missing initialization for transaction version
d158045 
* Added explicit default ctors/assign for copy/move to builder
* Changed  builder sign function to return void and pass transaction in by reference to avoid copies.
* Updated transaction tests to check for version.
@ghost
Copy link

ghost commented Aug 7, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Aug 7, 2019
@ciband
Copy link
Contributor Author

ciband commented Aug 7, 2019

Tests pass on Windows and Ubuntu for Windows. I am able to get it to fail on my "real" Ubuntu machine. Very weird. I will investigate.

@ciband
fix: Increase the JSON document size
24c98e5 
Increased the JSON document size to allow for the addition
of the version field.
@codecov-io
Copy link

Codecov Report

Merging #124 into develop will decrease coverage by 0.1%.
The diff coverage is 82.35%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #124      +/-   ##
===========================================
- Coverage    91.52%   91.41%   -0.11%     
===========================================
  Files           30       30              
  Lines          861      874      +13     
===========================================
+ Hits           788      799      +11     
- Misses          73       75       +2
Impacted Files Coverage Δ
src/include/cpp-crypto/transactions/transaction.h 66.66% <ø> (ø) ⬆️
src/transactions/transaction.cpp 89.41% <100%> (+0.47%) ⬆️
src/transactions/builder.cpp 76.81% <81.25%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03288a3...24c98e5. Read the comment docs.

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Aug 7, 2019
@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Aug 7, 2019
@ghost
Copy link

ghost commented Aug 7, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 2c0fe64 into ArkEcosystemArchive:develop Aug 7, 2019
@ghost
Copy link

ghost commented Aug 7, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

ciband added a commit to ciband/cpp-crypto that referenced this pull request Aug 7, 2019
@ciband
fix: Add missing initialization for transaction version (ArkEcosystem…
be6412f 
…Archive#124)
@ghost ghost mentioned this pull request Aug 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Medium Less than 256 lines changed. Status: Contributor Approved The pull request has been approved by a contributor. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciband @codecov-io @faustbrian