build: Add support for out of source build #126
Conversation
Updated build to be out of source to clean up the workspace and added build scripts to enforce this. Corrected long standing compile error with cmake_example. Removed cmake_example .gitmodules file. This historically caused git to do funny things having a nested .gitmodules in the source tree. Commented out the submodule clone in the CMakeList.txt and setup the build script to mimic the submodule clone by copying the cpp-crypto source into the correct directory.
Added Windows build scripts to do out of source build.
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
Your pull request doesn't follow our contribution guidelines. Please review and correct it. |
ghost
mentioned this pull request
ciband
changed the title
Updated build and run tests steps for Linux, Mac, and Windows.
|
Perfect. This looks good to go, @faustbrian |
Codecov Report
@@ Coverage Diff @@
## develop #126 +/- ##
========================================
Coverage 91.38% 91.38%
========================================
Files 34 34
Lines 871 871
========================================
Hits 796 796
Misses 75 75Continue to review full report at Codecov.
|
Added missing include to arkCrypto.h rollup header. This was causing the sample cmake program to fail to build in CI.
The previous commit include a header which has moved locations and is now not publicly available.
|
There is still an issue with cmake_examples compiling. This is a bigger issue than this PR. The examples uses HexToBytes whose header used to be public but is now private. This is what is causing the examples to not build (but CI still passes). My vote would be merge this PR as it and tackle the examples in a future PR. @sleepdefic1t and I can talk about how we want to handle it (e.g. make header public, change usage, etc..) |
faustbrian
added
the
Bounty: Tier 4
ghost
added
the
Status: Contributor Approved
|
A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
Updated build to be out of source to clean up the workspace
and added build scripts to enforce this.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: