Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crypto): fix crash in tests #146

Merged
merged 1 commit into from Sep 25, 2019
Merged

fix(crypto): fix crash in tests #146

merged 1 commit into from Sep 25, 2019

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Sep 25, 2019 •
edited

FIxed bug where an unallocated vector was being used.
Changed to use fix array since the buffer was never dynamic.

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ciband
fix (crypto): fix crash in tests
e080907 
FIxed bug where an unallocated vector was being used.
Changed to use fix array since the buffer was never dynamic.
@ghost
Copy link

ghost commented Sep 25, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link

ghost commented Sep 25, 2019

Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost ghost added the Complexity: Low Less than 64 lines changed. label Sep 25, 2019
@ciband
Copy link
Contributor Author

ciband commented Sep 25, 2019

Arduino build breakage is not a result of this change.

@sleepdefic1t
Copy link
Contributor

Yeah, looks like the Arduino workflow isn’t finding the demo sketch.

Not related to this PR.

I’ll look into fixing it.

Good catch on the PR 👍
Thank you, @ciband

@sleepdefic1t
Copy link
Contributor

@faustbrian
This one’s good to go 👍

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Sep 25, 2019
@ghost
Copy link

ghost commented Sep 25, 2019

A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Sep 25, 2019
@faustbrian faustbrian changed the title fix (crypto): fix crash in tests fix(crypto): fix crash in tests Sep 25, 2019
@faustbrian faustbrian merged commit ace8a26 into ArkEcosystemArchive:develop Sep 25, 2019
@ghost
Copy link

ghost commented Sep 25, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@ghost ghost mentioned this pull request Sep 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

@kristjank kristjank Awaiting requested review from kristjank

@spkjp spkjp Awaiting requested review from spkjp

Assignees
No one assigned
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ciband @sleepdefic1t @faustbrian