fix: library config examples' paths #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misc: merge from upstream
- list ArduinoJson as a dependency. - add Arduino sketch path to config. - fix the 'platformio_example' path.
This reverts commit 55d830b.
PlatformIO uses globbing for 'examples' paths. https://docs.platformio.org/en/latest/librarymanager/config.html#examples
|
@sleepdefic1t Thanks for submitting this pull request, a maintainer will get back to you shortly! |
|
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
requested review from
ghost
added
Status: Needs Review
faustbrian
approved these changes
Feb 8, 2019
|
@sleepdefic1t A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
ghost
added
the
Status: Contributor Approved
|
@sleepdefic1t Your pull request has been merged but was not assigned a bounty tier. @air1one @faustbrian - please assign a bounty tier to this pull request in the next few days. |
ghost
removed
the
Status: Needs Review
ghost
mentioned this pull request
ciband
pushed a commit
to ciband/cpp-crypto
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PlatformIO uses globbing in
library.jsonfor the 'examples' paths.This PR drops explicit path naming in favor of the wildcard(*) syntax.
This allows SDK examples to be properly displayed in the PIO library manager.
Types of changes
Checklist