fix: Remove Unneeded/Redundant Manifest Fields #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misc: merge from upstream
- list ArduinoJson as a dependency. - add Arduino sketch path to config. - fix the 'platformio_example' path.
This reverts commit 55d830b.
- Releases should include all files from the 'root/' dir for the source code zip. - per PIO, the "examples field" not being present defaults to the paths that are already shown. So this part is just redundant.
|
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
requested review from
ghost
added
Status: Needs Review
|
@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 4fbf5681d102112f389373ffa1c55e8a675714c7. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
Failing test is known in #7, the changes in this PR do not affect this failure. |
faustbrian
approved these changes
Feb 10, 2019
ghost
removed
the
Status: Needs Review
ghost
mentioned this pull request
ciband
pushed a commit
to ciband/cpp-crypto
that referenced
this pull request
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR removes the following fields from
library.json:Releases should include all files and folders from the
root/dir for the source code zip.Also, Per PIO, the "examples" field not being present defaults to the paths that are already shown. So this part is just redundant.
Types of changes
Checklist