Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Arduino CircleCI Config #61

Merged
merged 17 commits into from
Feb 13, 2019
Merged

test: Add Arduino CircleCI Config #61

merged 17 commits into from
Feb 13, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR adds the necessary configuration for CircleCI to compile the Cpp-Crypto library via Arduino-CLI. If the Cpp-Crypto library builds successfully via Arduino-CLI, the test is considered to have passed.
At this time, only the ESP32 chipset is supported in this test.

note: CI will fail until #60 is merged, and this PR is updated.

Reasons for this change:

  • Promote Arduino IDE compatibility.
  • Improve maintainability of an incoming Arduino branch for the Arduino IDE Library Manager src.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@ghost
Copy link

ghost commented Feb 11, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested review from air1one and faustbrian February 11, 2019 23:04
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements. labels Feb 11, 2019
@ghost
Copy link

ghost commented Feb 11, 2019

@faustbrian The ci/circleci: build-arduino-default job is failing as of 80eede35393a03686db4aea832fe0f905231e956. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@faustbrian faustbrian merged commit 502442d into ArkEcosystemArchive:master Feb 13, 2019
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 13, 2019
@sleepdefic1t sleepdefic1t deleted the test/arduino-ci branch February 15, 2019 17:50
ciband pushed a commit to ciband/cpp-crypto that referenced this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Low Less than 64 lines changed. Test: Unit The issue or pull request is related to unit tests for testing individual elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants