-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump version #66
chore: bump version #66
Conversation
misc: merge from upstream
- list ArduinoJson as a dependency. - add Arduino sketch path to config. - fix the 'platformio_example' path.
This reverts commit 55d830b.
'0.2.0' >> '0.3.0'
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
- also add extras dir to export
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 29 29
Lines 805 805
=======================================
Hits 707 707
Misses 98 98 Continue to review full report at Codecov.
|
@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 3c09e61ca41fd6fe2c7ac03b1d4db4b24e352b74. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@@ -7,6 +7,30 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## Unreleased | |||
|
|||
## [0.3.0] - 2019-02-16 | |||
## [0.3.0-arduino] - 2019-02-16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we really required to do duplicate tags for the same code? Shouldn't everything work with a single tag now that the arduino config is setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and no.
Arduino branch will have a different folder structure compatible with Arduino’s library manager.
The Arduino tags should target the Arduino branch; regular tag should target master.
What’s basically going on:
master | 0.3.0
master >> Arduino Script >> arduino branch | 0.3.0-arduino
Using two releases is per @kristjank and discussion here:
https://forum.arduino.cc/index.php?topic=596617.0
The Library Manager indexer job just works off of Git tags. As long as the tag points to something that is compliant, it's fine. You could have one branch of the repo with the Library Manager compatible structure that you point the Library Manager tags at, and another branch of the repository with your existing structure. You should also be able to create tags that point to the non-compliant branch and the Library Manager indexer should just ignore those.
The alternative would be a completely separate Arduino repo with nearly identical code, just laid out differently than PlatformIO and Desktop builds.
I’m open to more discussion if you feel it’s warranted though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense now, thanks for the link.
Proposed changes
This PR bumps version to
0.3.0
and will match incoming0.3.0-arduino
tag.see #65 for more info.
Types of changes
Checklist