This repository has been archived by the owner on Nov 27, 2019. It is now read-only.
feat: message verification #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ItsANameToo there have been some changes in the last commits that should make it possible to finish this now. |
|
@ItsANameToo Before you commit please also move |
faustbrian
reviewed
Jul 12, 2018
lib/utils/ec_key.ex
Outdated
| BtcCore.decompress(public_key) | ||
| end | ||
|
|
||
| def verify_message(message, signature, public_key) do |
There was a problem hiding this comment.
This method should be inside message.ex as it is specific to the message entity.
faustbrian
reviewed
Jul 12, 2018
lib/utils/ec_key.ex
Outdated
| @@ -44,6 +44,15 @@ defmodule ArkEcosystem.Crypto.Utils.EcKey do | |||
| |> private_key_to_address(network_address) | |||
| end | |||
|
|
|||
| def pubkey_from_hex(public_key) do | |||
There was a problem hiding this comment.
This method should be named public_key_from_hex. Abbreviations don't really offer any benefit here.
|
@supaiku0 will do :) |
ItsANameToo
changed the title
|
@faustbrian you can take a look again |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds message verification and message signing / verification tests.
Based on the verify functionality implemented by @supaiku0
Types of changes
Checklist