This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
refactor: hydrate wallets to respect the data structure contract #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Medium
faustbrian
force-pushed
the
hydratev3
branch
2 times, most recently
from
edc9ae0
to
6fe087a
Compare
ItsANameToo
approved these changes
Oct 8, 2020
|
tests are rekt |
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adjusting the whole explorer to the new data structures, it makes more sense to use a DTO-ish approach by normalizing the data before it leaves the service. This will keep the explorer functional without any major changes because we can return wallet objects that match the previous format.