feat: implement `WalletData#isDelegate/isKnown/isMultiSignature/isSec…

…ondSignature` (#477)

packages/platform-sdk-ark/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		return BigNumber.make(this.data.votes);
 	}
+
+	public isDelegate(): boolean {
+		return !!this.data.username;
+	}
+
+	public isKnown(): boolean {
+		return false;
+	}
+
+	public isMultiSignature(): boolean {
+		return !!this.data.multiSignature;
+	}
+
+	public isSecondSignature(): boolean {
+		return !!this.data.secondPublicKey;
+	}
 }

packages/platform-sdk-atom/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-btc/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-eos/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-eth/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-lsk/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		return BigNumber.make(this.data.votes);
 	}
+
+	public isDelegate(): boolean {
+		return !!this.data.delegate;
+	}
+
+	public isKnown(): boolean {
+		return false;
+	}
+
+	public isMultiSignature(): boolean {
+		return false;
+	}
+
+	public isSecondSignature(): boolean {
+		return !!this.data.secondPublicKey;
+	}
 }

packages/platform-sdk-neo/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-profiles/src/wallet.ts

@@ -174,28 +174,24 @@ export class Wallet {
 	 */
 
 	public isDelegate(): boolean {
-		// TODO: automatically determine this
-		return this.data().has(WalletFlag.SecondSig);
+		return this.#wallet.isDelegate();
 	}
 
 	public isKnown(): boolean {
-		// TODO: automatically determine this
-		return this.data().has(WalletFlag.Known);
+		return this.#wallet.isKnown();
 	}
 
 	public isLedger(): boolean {
 		// TODO: automatically determine this
 		return this.data().has(WalletFlag.Ledger);
 	}
 
-	public isMultiSig(): boolean {
-		// TODO: automatically determine this
-		return this.data().has(WalletFlag.MultiSig);
+	public isMultiSignature(): boolean {
+		return this.#wallet.isMultiSignature();
 	}
 
-	public isSecondSig(): boolean {
-		// TODO: automatically determine this
-		return this.data().has(WalletFlag.SecondSig);
+	public isSecondSignature(): boolean {
+		return this.#wallet.isSecondSignature();
 	}
 
 	public isStarred(): boolean {

packages/platform-sdk-trx/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-xlm/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-xmr/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk-xrp/src/dto/wallet.ts

@@ -29,4 +29,20 @@ export class WalletData extends DTO.AbstractWalletData implements Contracts.Wall
 	public votes(): BigNumber | undefined {
 		throw new Exceptions.NotImplemented(this.constructor.name, "votes");
 	}
+
+	public isDelegate(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isDelegate");
+	}
+
+	public isKnown(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isKnown");
+	}
+
+	public isMultiSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isMultiSignature");
+	}
+
+	public isSecondSignature(): boolean {
+		throw new Exceptions.NotImplemented(this.constructor.name, "isSecondSignature");
+	}
 }

packages/platform-sdk/src/contracts/coins/data.ts

@@ -43,6 +43,15 @@ export interface WalletData {
 
 	votes(): BigNumber | undefined;
 
+	// Flags
+	isDelegate(): boolean;
+
+	isKnown(): boolean;
+
+	isMultiSignature(): boolean;
+
+	isSecondSignature(): boolean;
+
 	toObject(): KeyValuePair;
 }
 

packages/platform-sdk/src/dto/wallet.ts

@@ -21,6 +21,15 @@ export abstract class AbstractWalletData {
 
 	abstract votes(): BigNumber | undefined;
 
+	// Flags
+	abstract isDelegate(): boolean;
+
+	abstract isKnown(): boolean;
+
+	abstract isMultiSignature(): boolean;
+
+	abstract isSecondSignature(): boolean;
+
 	public toObject(): KeyValuePair {
 		return {
 			address: this.address(),