Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: always treat nonce as BigNumber #200

Merged
merged 2 commits into from
May 12, 2020
Merged

refactor: always treat nonce as BigNumber #200

merged 2 commits into from
May 12, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented May 12, 2020

Resolves #195

Brian Faust added 2 commits May 12, 2020 09:34
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #200 into master will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   81.56%   82.05%   +0.49%     
==========================================
  Files          26       24       -2     
  Lines         743      624     -119     
  Branches       92       77      -15     
==========================================
- Hits          606      512      -94     
+ Misses        136      111      -25     
  Partials        1        1              
Impacted Files Coverage Δ
src/services/identity/address.ts 79.16% <0.00%> (-8.84%) ⬇️
src/services/identity/public-key.ts 81.25% <0.00%> (-8.75%) ⬇️
src/services/identity/private-key.ts 90.00% <0.00%> (-3.34%) ⬇️
src/services/message.ts 94.11% <0.00%> (-1.34%) ⬇️
src/utils/crypto.ts
src/utils/hash.ts
src/dto/transaction.ts 90.47% <0.00%> (+0.23%) ⬆️
src/services/client.ts 86.11% <0.00%> (+2.21%) ⬆️
src/services/transaction.ts 61.94% <0.00%> (+2.74%) ⬆️
src/services/identity/keys.ts 94.11% <0.00%> (+9.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6942cc6...03c1df7. Read the comment docs.

@faustbrian faustbrian merged commit e6b0b99 into master May 12, 2020
@faustbrian faustbrian deleted the bn-nonce branch May 12, 2020 06:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat nonce as BigInt for everything
1 participant