Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

refactor: remove TransactionData#nonce method #223

Merged
merged 2 commits into from
May 13, 2020
Merged

refactor: remove TransactionData#nonce method #223

merged 2 commits into from
May 13, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented May 13, 2020

The nonce isn't relevant outside of signing transactions.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #223 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   81.85%   81.78%   -0.08%     
==========================================
  Files          26       26              
  Lines         766      763       -3     
  Branches      101       99       -2     
==========================================
- Hits          627      624       -3     
  Misses        137      137              
  Partials        2        2              
Impacted Files Coverage Δ
src/dto/transaction.ts 90.00% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 710796c...a395058. Read the comment docs.

@faustbrian faustbrian merged commit 37b9d7f into master May 13, 2020
@faustbrian faustbrian deleted the tx-nonce branch May 13, 2020 03:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant