Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

fix(profiles): throw an exception if the ID of a newly signed transaction is a duplicate #653

Merged
merged 1 commit into from Aug 12, 2020

Conversation

faustbrian
Copy link
Contributor

No description provided.

@faustbrian faustbrian changed the title wip fix(profiles): throw an exception if the ID of a newly signed transaction is a duplicate Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #653 into master will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   68.26%   68.20%   -0.07%     
==========================================
  Files          88       90       +2     
  Lines        1727     1758      +31     
  Branches      167      172       +5     
==========================================
+ Hits         1179     1199      +20     
- Misses        498      507       +9     
- Partials       50       52       +2     
Flag Coverage Δ
#unit 68.20% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...profiles/src/wallets/wallet-transaction-service.ts 31.66% <0.00%> (-1.10%) ⬇️
packages/platform-sdk-atom/src/utils/crypto.ts 88.88% <0.00%> (ø)
packages/platform-sdk-atom/src/utils/hash.ts 36.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f49e72...96bb7c7. Read the comment docs.

@faustbrian faustbrian merged commit 0f58708 into master Aug 12, 2020
@faustbrian faustbrian deleted the signduplicate branch August 12, 2020 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant