This repository has been archived by the owner on Jul 7, 2021. It is now read-only.
refactor(xrp): use ripple-lib connection for API requests #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running into an issue with mocking the WebSocket requests that
ripple-lib
sends, will need to figure out how to intercept them withnock
.Update 1
Doesn't seem to be possible to mock
websocket
with nock nock/nock#129 so might need to mock the whole module via jest.Update 2
Ripple runs a local server that replies with stub data https://github.com/ripple/ripple-lib/blob/f1c1c7033a554823b489fd3c53d27ee12fc76ed1/test/setup-api.ts#L6-L22 so will probably have to do the same.