[MIRROR] [MIRROR] Chutes no longer play sounds on top of each other. Pipe ejections are a bit quieter too #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions are a bit quieter too (#2713) * Chutes no longer play sounds on top of each other. Pipe ejections are a bit quieter too (#83470) ## About The Pull Request Chutes were playing a sound per item in a stack because the condition was that the last played sound happened before worldtime+1 which was always the case, that's in the future. They now only play a single sound when multiple items enter them at once. Outlets functioned correctly but the sound for midpipe ejections was a bit overpowering, so I deadened it a bit(-4 LUFS). Tested. No observed effect on consecutive insertions. ## Why It's Good For The Game It is often the case that a conveyor with a large stack of items may be activated, pushing a large quantity of items into a chute, which would then fry the eardrums of all those nearby. ## Changelog :cl: sound: Disposal chutes will no longer play a sound for each item when many items enter it at once /:cl: * Chutes no longer play sounds on top of each other. Pipe ejections are a bit quieter too --------- Co-authored-by: Capsandi <38051413+Capsandi@users.noreply.github.com> Co-authored-by: NovaBot13 <novasector13@gmail.com>
…tions are a bit quieter too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: NovaSector/NovaSector#2713
Original PR: tgstation/tgstation#83470
About The Pull Request
Chutes were playing a sound per item in a stack because the condition was that the last played sound happened before worldtime+1 which was always the case, that's in the future. They now only play a single sound when multiple items enter them at once.
Outlets functioned correctly but the sound for midpipe ejections was a bit overpowering, so I deadened it a bit(-4 LUFS).
Tested. No observed effect on consecutive insertions.
Why It's Good For The Game
It is often the case that a conveyor with a large stack of items may be activated, pushing a large quantity of items into a chute, which would then fry the eardrums of all those nearby.
Changelog
🆑
sound: Disposal chutes will no longer play a sound for each item when many items enter it at once
/:cl: