Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cancellable TerminalWriteEvents #46

Merged
merged 2 commits into from
Apr 19, 2020

Conversation

Spartan322
Copy link
Collaborator

@Spartan322 Spartan322 commented Apr 18, 2020

Added TerminalEvent, TerminalWriteEvent, TerminalWriteAppendEvent, and TerminalWriteLineEvent
Injected TerminalEvent hooks
Corrects possible double calls for TerminalWriteEvent
Addresses part of #44

Added TerminalEvent, TerminalWriteEvent, TerminalWriteSingleEvent, and TerminalWriteLineEvent
Injected TerminalEvent hooks
Corrects possible double calls for TerminalWriteEvent
Addresses part of #44
@Spartan322
Copy link
Collaborator Author

If you want I could also try to add TerminalDrawEvent to finalize the current #44 this time.

@Spartan322 Spartan322 mentioned this pull request Apr 18, 2020
5 tasks
@Fayti1703
Copy link
Contributor

I personally think having to call two events like this is a bit awkward -- perhaps the EventManager should instead automatically call up the class hierarchy?

@Spartan322
Copy link
Collaborator Author

I personally think having to call two events like this is a bit awkward -- perhaps the EventManager should instead automatically call up the class hierarchy?

That actually wouldn't work in this case anyway because of how Matt separated the write methods, write will always call writeLine at least once if its not called before any writeLine call.

TerminalWriteSingleEvent -> TerminalWriteAppendEvent
Made TerminalWriteEvent parent of Append and Line events
@Spartan322 Spartan322 merged commit 0bc54e8 into develop Apr 19, 2020
@Spartan322 Spartan322 deleted the feature/TerminalWriteEvents branch April 19, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants