Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement] View models implement IDelegatable #245

Merged
merged 2 commits into from
Dec 30, 2022
Merged

[improvement] View models implement IDelegatable #245

merged 2 commits into from
Dec 30, 2022

Conversation

yoshiask
Copy link
Collaborator

Overview

Closes #241

Every relevant class in the ViewModel layer now exposes the model they wrap via IDelegatable<T>. See linked issue for details.

Checklist

This PR meets the following requirements:

  • Tested and contains NO breaking changes or known regressions.
  • Tested with the upstream branch merged in.
  • Tests have been added for bug fixes / features (or this option is not applicable)
  • All new code has been documented (or this option is not applicable)
  • Headers have been added to all new source files (or this option is not applicable)

Additional info

Not provided

@yoshiask yoshiask added enhancement New feature or request sdk Related to the Strix Music SDK labels Dec 29, 2022
@yoshiask yoshiask added this to the Road to 0.1.0 milestone Dec 29, 2022
@yoshiask yoshiask self-assigned this Dec 29, 2022
@Arlodotexe Arlodotexe merged commit 93da52b into dev Dec 30, 2022
@Arlodotexe Arlodotexe deleted the refactor/vm-idelegatable branch December 30, 2022 01:32
@Arlodotexe Arlodotexe linked an issue Jan 3, 2023 that may be closed by this pull request
ViewModels should implement IDelegatable<T> #241
Closed
@Arlodotexe Arlodotexe mentioned this pull request Apr 26, 2023
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees

@yoshiask yoshiask

Labels
enhancement New feature or request sdk Related to the Strix Music SDK
Projects
None yet
Milestone
Road to 0.1.0
Development

Successfully merging this pull request may close these issues.

ViewModels should implement IDelegatable<T>
2 participants
@yoshiask @Arlodotexe