Send connection profile config as json and validate it #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeisen
force-pushed
the
fix-connection-profile-config
branch
from
33f5dad
to
005953f
Compare
jbeisen
changed the title
jbeisen
force-pushed
the
fix-connection-profile-config
branch
from
005953f
to
04fae1b
Compare
mwylde
approved these changes
Aug 23, 2023
mwylde
reviewed
Aug 23, 2023
| @@ -178,7 +178,8 @@ impl<C: Connector> ErasedConnector for C { | |||
| Ok(self.config_description(self.parse_config(s)?)) | |||
| } | |||
|
|
|||
| fn validate_config(&self, _: &serde_json::Value) -> Result<(), serde_json::Error> { | |||
| fn validate_config(&self, config: &serde_json::Value) -> Result<(), serde_json::Error> { | |||
| self.parse_config(config)?; | |||
There was a problem hiding this comment.
This change needs to be made for validate_table as well — looks like we lost the validation logic in the refactor
jbeisen
force-pushed
the
fix-connection-profile-config
branch
from
04fae1b
to
c05fde5
Compare
mwylde
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.