Sync logging #718
Merged
Sync logging #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logging stack uses tracing_subscriber's non-blocking appender. In theory this can reduce latency and the impact of logging when there is a high volume of logs being written. However, in practice this is unlikely in Arroyo unless users are running with DEBUG logging. However, using the non-blocking appender causes a 4MB allocation for the buffer (tokio-rs/tracing#2415) which is undesirable for low-memory settings.
This PR changes the default strategy to the normal blocking stderr writer, while allowing users to enable non-blocking mode by enabling the
log.nonblockingconfig.