Add asArray option to recursively transform into arrays #10
Conversation
| else | ||
| { | ||
| // Fallback for stdClass objects | ||
| return json_decode(json_encode($val), true); |
There was a problem hiding this comment.
I think array casting with return (array) $val; would do the same in less time.
|
Looks good to me. 👍 But please replace the json_decode/encode line with array casting. And some tests for |
|
An array cast doesn't work with nested stdClass, which would not be transformed to array. See this: https://gist.github.com/fcastillo-es/03305bbbd51f5ed00b8f That would cause failure with valid meta members. Tell me what you think about it. I'll take care of the tests meanwhile. |
|
You are right, I've forgotten about nested classes. Alright then. |
|
Ok, I added some tests. Basically duplicating all the assertSame assertions with fullArray true. Also added an assertion to each integration test. I think this is enough. By the way, I think I messed up a commit when trying to rebase and maybe I should create another pull request to have a clean history. Tell me when you can. |
|
Thanks! Looks goot to me.
I thinks thats not a problem. You rebased your commit from #9. |
Add asArray() option to recursively transform into arrays
As you commented in #8 you wanted this functionality optional I added it disabled by default in this PR.