Skip to content
This repository has been archived by the owner on Nov 22, 2020. It is now read-only.

Fixed a problem where the text color of the float label was changed t… #16

Merged
merged 1 commit into from
Jan 2, 2016

Conversation

alanihre
Copy link

Fixed a problem where the text color of the float label was changed to active or passive color upon UIResponder changes even though the change could not be performed.

…o active or passive color upon UIResponder changes even though the change could not be performed.
@ArtSabintsev
Copy link
Owner

Will look into this tonight - thanks!

@ArtSabintsev
Copy link
Owner

Would you mind sending me a sample project with repeatable steps? Thank you for your help in solving this issue.

@alanihre
Copy link
Author

Hi,
Thank you for looking into this. The bug occurs when the text field delegate method textFieldShouldBeginEditing: returns NO. This should cause the text field to not become first responder but when the user taps on the text field the float label placeholder is still highlighted even though the text field can't become first responder.

I have attached a demo project which demonstrates the issue.
UIFloatLabelTextFieldBugDemo.zip

@ArtSabintsev
Copy link
Owner

Got it - thanks! Accepting the PR.

ArtSabintsev added a commit that referenced this pull request Jan 2, 2016
Fixed a problem where the text color of the float label was changed t…
@ArtSabintsev ArtSabintsev merged commit debe632 into ArtSabintsev:master Jan 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants